From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/5] ethdev: Rename macros of packet classification type Date: Thu, 24 Jul 2014 10:19:45 +0200 Message-ID: <5763244.xFk97hyylc@xps13> References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com> <2490690.EmSZ5vBN3i@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Zhang, Helin" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-07-24 08:14, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2014-07-24 14:42, Helin Zhang: > > > For better understanding, 'PCTYPE' was added to the name of i40e RSS > > > shift macros. > > > > > > Signed-off-by: Helin Zhang > > > > > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31 > > > +#define ETH_PCTYPE_NONF_IPV4_UDP 31 > > > > Why is it clearer? I don't understand what means PCTYPE. > > It is 'packet classification type' defined in data sheet, and widely used. Widely used? No it seems to be an i40e naming. Which datasheet are you pointing? > It is not just for RSS only, it can be used for flow director possibly. > That's why I think it would be better to rename it with PCTYPE names. At least, you should add a comment in the code to explain the meaning. Thank you -- Thomas