From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v6 04/27] net/thunderx/base: add mbox APIs
 for PF/VF communication
Date: Tue, 21 Jun 2016 14:41:39 +0100
Message-ID: <57694413.2010901@intel.com>
References: <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1466170194-28393-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1466170194-28393-5-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com,
 Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
 Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>,
 Zyta Szpak <zyta.szpak@semihalf.com>,
 Slawomir Rosek <slawomir.rosek@semihalf.com>,
 Radoslaw Biernacki <rad@semihalf.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 711DAC35C
 for <dev@dpdk.org>; Tue, 21 Jun 2016 15:41:44 +0200 (CEST)
In-Reply-To: <1466170194-28393-5-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/17/2016 2:29 PM, Jerin Jacob wrote:
> DPDK nicvf driver doesn't have access to NIC's PF address space.
> Introduce a mailbox mechanism to communicate with PF driver through
> shared 128bit register interface.
>=20
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
> Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>
> Signed-off-by: Zyta Szpak <zyta.szpak@semihalf.com>
> Signed-off-by: Slawomir Rosek <slawomir.rosek@semihalf.com>
> Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>

...

> +
> +static inline const char *
> +nicvf_mbox_msg_str(int msg)
> +{
> +	assert(msg >=3D 0 && msg < NIC_MBOX_MSG_MAX);
> +	/* undefined messages */
> +	if (mbox_message[msg] =3D=3D NULL)
> +		msg =3D 0;
> +	return mbox_message[msg];
> +}

With clang getting following compile error:

=3D=3D Build drivers/net/thunder
  CC nicvf_mbox.o
/root/development/dpdk-next-net/drivers/net/thunderx/base/nicvf_mbox.c:68=
:1:
error: unused function 'nicvf_mbox_msg_str' [-Werror,-Wunused-function]
nicvf_mbox_msg_str(int msg)
^
1 error generated.
/root/development/dpdk-next-net/mk/internal/rte.compile-pre.mk:126:
recipe for target 'nicvf_mbox.o' failed


It looks like nicvf_mbox_msg_str() only called within logging functions
which can depends on DEBUC_X config options.


Regards,
ferruh