From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods Date: Tue, 21 Jun 2016 16:56:27 +0200 Message-ID: <5769559B.4010707@6wind.com> References: <1464663966-8122-1-git-send-email-jianbo.liu@linaro.org> <574DE5D6.2040001@6wind.com> <20160601060028.GA3823@localhost.localdomain> <20160602093006.GA6794@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Jerin Jacob , Jianbo Liu Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id E66E2C37A for ; Tue, 21 Jun 2016 16:56:35 +0200 (CEST) In-Reply-To: <20160602093006.GA6794@localhost.localdomain> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 06/02/2016 11:30 AM, Jerin Jacob wrote: > On Thu, Jun 02, 2016 at 05:04:13PM +0800, Jianbo Liu wrote: >> On 1 June 2016 at 14:00, Jerin Jacob wrote: >>> On Wed, Jun 01, 2016 at 11:29:47AM +0800, Jianbo Liu wrote: >>>> On 1 June 2016 at 03:28, Olivier MATZ wrote: >>>>> Hi Jianbo, >>>>> >>>>> On 05/31/2016 05:06 AM, Jianbo Liu wrote: >>>>>> Change the inline function to macro with parameters >>>>>> >>>>>> Signed-off-by: Jianbo Liu >>>>>> >>>>>> [...] >> [...] >>>> It's for performance consideration, and only on armv8a platform. >>> >>> Strictly it is not armv8 specific, IA also implemented this API with >>> _MM_HINT_NTA hint. >> >> I mean this patch is only for ixgbe vector PMD on armv8 platform. >> >>> >>> Do we really need non-temporal/transient version of prefetch for ixgbe? >> >> Strictly speaking, we don't have to since we don't know how APPs use >> the mbuf header. > > Then IMO it makes sense to keep the same behavior as x86 ixgbe driver. > Then on the upside, We may not need the new macros for part prefetching > > Jerin Knowing that http://www.dpdk.org/dev/patchwork/patch/13992/ has been submitted, I think this patch can be marked as closed in patchwork.