From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zyta Szpak Subject: Re: [PATCH v4 1/2] ethdev: remove get_reg_length callback Date: Tue, 28 Jun 2016 18:05:30 +0200 Message-ID: <5772A04A.9000805@semihalf.com> References: <1466688410-13826-1-git-send-email-zr@semihalf.com> <2151797.UCVmFz2S8u@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: remy.horton@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id A8FB82E8A for ; Tue, 28 Jun 2016 18:05:31 +0200 (CEST) Received: by mail-lf0-f44.google.com with SMTP id h129so14796733lfh.1 for ; Tue, 28 Jun 2016 09:05:31 -0700 (PDT) In-Reply-To: <2151797.UCVmFz2S8u@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OK On 27.06.2016 17:19, Thomas Monjalon wrote: > 2016-06-23 15:26, zr@semihalf.com: >> From: Zyta Szpak >> >> Version 4 of fixing the assumption of that device registers >> are always 32 bits long. rte_eth_dev_get_reg_length and >> rte_eth_dev_get_reg_info callbacks did not provide register size >> to the app in any way. It is needed to allocate proper number >> of bytes before retrieving registers content with >> rte_eth_dev_get_reg. This commit remove rte_eth_dev_get_reg_length >> callback and adds width parameter to reg_info struct which makes >> it possible to call rte_eth_dev_get_reg_info to get attributes >> first. The drivers using this callback fill width and length >> when call to function made with data=NULL. >> >> Signed-off-by: Zyta Szpak > Please do not mention patch revision in the commit log. > However you can add a changelog below the three dashes (with --annotate). > And please use --in-reply-to to keep revisions in the same thread. > Thanks