From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] ixgbe: fix compilation when offload flags disabled Date: Wed, 29 Jun 2016 13:35:15 +0200 Message-ID: <5773B273.3030203@6wind.com> References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> <1569745.6sBGvsO00c@xps13> <20160629101552.GE4720@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: konstantin.ananyev@intel.com, dev@dpdk.org, helin.zhang@intel.com, amint@icsi.berkeley.edu To: Bruce Richardson , Thomas Monjalon Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 6B25028BF for ; Wed, 29 Jun 2016 13:35:15 +0200 (CEST) In-Reply-To: <20160629101552.GE4720@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/29/2016 12:15 PM, Bruce Richardson wrote: > On Mon, Jun 27, 2016 at 07:05:45PM +0200, Thomas Monjalon wrote: >> 2016-06-27 17:44, Olivier Matz: >>> The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n >>> because the macro has not the proper number of parameters. >> >> We really need to understand why this build option is needed. >> Target: zero build option. > > Agreed. However, we are where we are right now, and this build option is there. > > Olivier, can you do a V2 of this patch based on dpdk-next-net/rel_16_07, since > the code in question has actually moved on that branch. Sure, will do. > Out of interest, can you perhaps also give a little more detail on how to > reproduce the issue, as turning off the setting fails to show up a build > problem for me with either gcc or clang, at -O3 or -O0. That's strange, I just set CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n to reproduce the issue. I'll check on dpdk-next-net/rel_16_07 and add more details, like the output of the compiler. Thanks, Olivier