From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] doc: announce ABI change for mbuf
	structure
Date: Wed, 20 Jul 2016 09:54:06 +0100
Message-ID: <578F3C2E.1050909@intel.com>
References: <1468936875-1652-1-git-send-email-olivier.matz@6wind.com>
 <1468998974-3040-1-git-send-email-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: jerin.jacob@caviumnetworks.com, thomas.monjalon@6wind.com,
 bruce.richardson@intel.com
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 803DD3777
 for <dev@dpdk.org>; Wed, 20 Jul 2016 10:54:09 +0200 (CEST)
In-Reply-To: <1468998974-3040-1-git-send-email-olivier.matz@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/20/2016 8:16 AM, Olivier Matz wrote:
> For 16.11, the mbuf structure will be modified implying ABI breakage.
> Some discussions already took place here:
> http://www.dpdk.org/dev/patchwork/patch/12878/
>=20
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>=20
> v1->v2:
> - reword the sentences to keep things more open, as suggested by Bruce
>=20
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_note=
s/deprecation.rst
> index f502f86..b9f5a93 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,3 +41,9 @@ Deprecation Notices
>  * The mempool functions for single/multi producer/consumer are depreca=
ted and
>    will be removed in 16.11.
>    It is replaced by rte_mempool_generic_get/put functions.
> +
> +* ABI changes are planned for 16.11 in the ``rte_mbuf`` structure: som=
e fields
> +  may be reordered to facilitate the writing of ``data_off``, ``refcnt=
``, and
> +  ``nb_segs`` in one operation, because some platforms have an overhea=
d if the
> +  store address is not naturally aligned. Other mbuf fields, such as t=
he
> +  ``port`` field, may be moved or removed as part of this mbuf work.
>=20

Not directly related to this patch, but generally for deprecation
notices, does it make sense to tag explicitly which library effected, lik=
e:

* librte_mbuf [perhaps with version here]:
  Explanation about deprecation ...

For this case it is more clear which library effected, but sometimes
that is not obvious from deprecation notice.

Also when checked for if specific library effected, it is harder to find
with current notes.

Thanks,
ferruh