From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v6 05/17] eal: introduce init macros Date: Mon, 1 Aug 2016 16:30:20 +0530 Message-ID: <579F2BC4.3060809@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-6-git-send-email-shreyansh.jain@nxp.com> <20160713112043.2fd847ca@jvn> <20160713193430.65b6df9c@jvn> <578722DB.3030900@nxp.com> <20160714175707.43755987@jvn> <5788BF88.3060607@nxp.com> <5799D20A.4020804@nxp.com> <20160730101455.612818ad@jvn> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , To: Jan Viktorin Return-path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0057.outbound.protection.outlook.com [104.47.40.57]) by dpdk.org (Postfix) with ESMTP id 457992BDE for ; Mon, 1 Aug 2016 12:59:20 +0200 (CEST) In-Reply-To: <20160730101455.612818ad@jvn> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jan, On Saturday 30 July 2016 01:44 PM, Jan Viktorin wrote: > On Thu, 28 Jul 2016 15:06:10 +0530 > Shreyansh Jain wrote: > >> Hi Jan, >> >> On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: >>> On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > > [...] > >>>>>>> (drv).name = RTE_STR(nm); >>>>> >>>>> That is a miss from my side. >>>>> I will publish v7 with this. You want this right away or should I wait a little while (more reviews, or any pending additions as per Thomas's notes) before publishing? >>>> >>>> Please. The time is almost gone. 18/7/2016 is the release (according >>>> to the roadmap)... I have to fix it in my patchset, otherwise it >>>> does not build (after moving the .name from rte_pci_driver to >>>> rte_driver). >>>> >>> >>> I didn't consider 18/Jul. >>> Please go ahead. I will continue to send v7 _without_ the above change so that your patchset doesn't break. This way you will not get blocked because of me. >>> >> >> Now that we have already skipped the 16.07, I will fix this in my code and release an updated version as soon as 16.07 is officially available. Is that OK? > > Sure :). The thing is that during August-September, I've got significantly > less time for this then in June-July :/. That's why I was trying to fit in > the 16.07. Well, then lets try and get things out for review as soon as we can. I have sent across v7 of rte_driver set. Unfortunately, I forgot to add your sign-off. If the set works for you, can you bulk ack? > >> >> Also, I have fixed most review comments except [1]. I am still not sure of the impact of this change. So, I will publish the v7 without this and then probably a v8 in case this change has any impact. > > I have no idea about this. Hopefully, it's not a very serious thing. > >> That way we can have your patchset not blocked because of this series. > > Thank you! > >> >> [1] http://dpdk.org/ml/archives/dev/2016-July/044004.html > >> >> [...] >> >> >> - >> Shreyansh > > >