From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v3 03/16] mbuf: move packet type definitions in a new file Date: Tue, 11 Oct 2016 11:01:46 +0200 Message-ID: <57FCAA7A.6020201@6wind.com> References: <1472481335-21226-1-git-send-email-olivier.matz@6wind.com> <1475483937-21696-1-git-send-email-olivier.matz@6wind.com> <1475483937-21696-4-git-send-email-olivier.matz@6wind.com> <2178965.8ItUXrjgAs@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, cunming.liang@intel.com, john.mcnamara@intel.com, andrey.chilikin@intel.com, konstantin.ananyev@intel.com To: Thomas Monjalon Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 9FA7C6CC4 for ; Tue, 11 Oct 2016 11:01:50 +0200 (CEST) In-Reply-To: <2178965.8ItUXrjgAs@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 10/10/2016 04:52 PM, Thomas Monjalon wrote: > 2016-10-03 10:38, Olivier Matz: >> The file rte_mbuf.h starts to be quite big, and next commits >> will introduce more functions related to packet types. Let's >> move them in a new file. >> >> Signed-off-by: Olivier Matz >> --- >> lib/librte_mbuf/Makefile | 2 +- >> lib/librte_mbuf/rte_mbuf.h | 495 +---------------------------------- >> lib/librte_mbuf/rte_mbuf_ptype.h | 552 +++++++++++++++++++++++++++++++++++++++ > > Why not moving packet type and other packet flags in librte_net? > These are mbuf features. I can reverse the question: why moving them in librte_net? :)