From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 2/7] cxgbe: update link state when link speed changes Date: Mon, 5 Feb 2018 17:05:57 +0000 Message-ID: <57cd8be1-b01c-bf49-a0e1-676eb028cbed@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kumaras@chelsio.com, surendra@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com To: Rahul Lakkireddy , dev@dpdk.org Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DDB341B654 for ; Mon, 5 Feb 2018 18:06:00 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: > From: Kumar Sanghvi > > Original work by Surendra Mobiya > > Fixes: cdac6e2eeafc ("cxgbe: add link related functions") > Signed-off-by: Kumar Sanghvi > Signed-off-by: Rahul Lakkireddy > --- > drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c > index 6d56f3c1b..5a25125fe 100644 > --- a/drivers/net/cxgbe/cxgbe_ethdev.c > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > @@ -227,7 +227,8 @@ static int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev, > unsigned int work_done, budget = 4; > > cxgbe_poll(&s->fw_evtq, NULL, budget, &work_done); > - if (old_link->link_status == pi->link_cfg.link_ok) > + if (old_link->link_status == pi->link_cfg.link_ok && > + old_link->link_speed == pi->link_cfg.speed) As Stephen's patch tried to clean this up, link_update dev_ops return value is not very clear now and this return value not used at all in ethdev layer. And as far as I can see you are also not using this locally in driver, so there is no effect of updating this code, good or bad, I suggest postponing this update until return value cleared more. > return -1; /* link not changed */ > > eth_dev->data->dev_link.link_status = pi->link_cfg.link_ok; >