From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] doc: update mlx4 flow limitations Date: Mon, 12 Feb 2018 14:58:31 +0100 Message-ID: <5845713.HXRxCIfSL1@xps> References: <1518072954-19082-1-git-send-email-ophirmu@mellanox.com> <1944833.dayHpbUbTZ@xps> <20180212112307.GH4256@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ophir Munk , dev@dpdk.org, Moti Haimovsky , Olga Shern , Matan Azrad , ferruh.yigit@intel.com To: Adrien Mazarguil Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C68AA1B350 for ; Mon, 12 Feb 2018 14:58:41 +0100 (CET) In-Reply-To: <20180212112307.GH4256@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/02/2018 12:23, Adrien Mazarguil: > On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote: > > I think it's better to have some random thoughts than nothing. > > All the comments you gave in this thread deserve to be written in > > the documentation as soon as possible. > > Right, but as a side note in the meantime, more complete documentation is > already available in Doxygen format in mlx4_flow.c. *All* limitations are > also returned in plain text through error messages (rte_flow_error.message) > in the same file (git grep 'msg =' drivers/net/mlx4/mlx4_flow.c). OK, so we can just point to this file in the documentation and we are done. [...] > > Do you plan to provide a template or an example? > > I certainly would like to submit something with the plan I suggested, > unfortunately I don't have time to work on that at the moment. Is it worth the effort, given it is already documented in code?