From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] examples/ethtool: fix link with ixgbe
	shared lib
Date: Mon, 01 May 2017 22:12:03 +0200
Message-ID: <5858218.OA5nERF2Hd@xps>
References: <20170216161731.4590-1-mchandras@suse.de>
 <20170501201032.24028-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Remy Horton <remy.horton@intel.com>,
 Timothy Redaelli <tredaelli@redhat.com>
To: Markos Chandras <mchandras@suse.de>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 23DC65A44
 for <dev@dpdk.org>; Mon,  1 May 2017 22:12:05 +0200 (CEST)
In-Reply-To: <20170501201032.24028-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/05/2017 22:10, Thomas Monjalon:
> From: Markos Chandras <mchandras@suse.de>
> 
> When RTE_DEVEL_BUILD is unset, -rpath is unset.
> So the ethtool app cannot link with ixgbe shared library
> which is required by ethtool lib:
> 
> warning: librte_pmd_ixgbe.so.1, needed by
> examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/librte_ethtool.so,
> not found (try using -rpath or -rpath-link)
> 
> It is fixed by adding the library in the application link.
> 
> The library link is also improved to specify that this explicit link
> to ixgbe is needed only in the shared lib mode.
> 
> Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function")
> 
> Signed-off-by: Markos Chandras <mchandras@suse.de>
> Acked-by: Remy Horton <remy.horton@intel.com>
> Acked-by: Timothy Redaelli <tredaelli@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: add condition on CONFIG_RTE_BUILD_SHARED_LIB

Applied, thanks