From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH v1] lib/metrics: add check for invalid metric keys Date: Fri, 27 Jul 2018 08:00:34 +0100 Message-ID: <58583116-33e8-ae31-2b2f-079f3390bc47@intel.com> References: <20180706132119.9013-1-remy.horton@intel.com> <402f4c38-6ed2-e279-b6dc-e382b0efa250@intel.com> <3135038.1Nyv25uGYd@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , dev@dpdk.org, Ferruh Yigit To: harry.van.haaren@intel.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 479BB1DB8 for ; Fri, 27 Jul 2018 09:00:38 +0200 (CEST) In-Reply-To: <3135038.1Nyv25uGYd@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Harry, Can you add the following to the cheat-sheet? Don't do many patches these days, and I'm not the only one to miss these recently.. ..Remy On 26/07/2018 19:11, Thomas Monjalon wrote: > Remy, > You are not new to DPDK. Please pay attention to details: > - subject does not start with lib/ > - fixes of old commits must have Cc: stable@dpdk.org > > 20/07/2018 17:31, Ferruh Yigit: >> On 7/6/2018 2:21 PM, Remy Horton wrote: >>> This patchset adds a check to rte_metrics_update_values() >>> that prevents the updating of metrics when presented with >>> an invalid metric key. Previously, doing the latter could >>> result in a crash. >>> >>> Fixes: 349950ddb9c5 ("metrics: add information metrics library") >>> >>> Signed-off-by: Remy Horton >> >> Acked-by: Ferruh Yigit > > Applied, thanks > >