From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD
Date: Wed, 27 Feb 2019 11:21:14 +0000
Message-ID: <585db3f2-d9e6-1efd-b05f-7050758423a6@intel.com>
References: <20190226213424.10567-1-stephen@networkplumber.org>
 <20190226213424.10567-6-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Igor Romanov <Igor.Romanov@oktetlabs.ru>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org,
 Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 3BCB337B4
 for <dev@dpdk.org>; Wed, 27 Feb 2019 12:21:17 +0100 (CET)
In-Reply-To: <20190226213424.10567-6-stephen@networkplumber.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/26/2019 9:34 PM, Stephen Hemminger wrote:
> The sfc driver was still using RTE_LOGTYPE_PMD which was superseded
> by local logging.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/sfc/sfc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c
> index 898603884fa0..2cd7126015fd 100644
> --- a/drivers/net/sfc/sfc.c
> +++ b/drivers/net/sfc/sfc.c
> @@ -1115,12 +1115,12 @@ sfc_register_logtype(const struct rte_pci_addr *pci_addr,
>  		++lt_prefix_str_size; /* Reserve space for prefix separator */
>  		lt_str_size_max = lt_prefix_str_size + PCI_PRI_STR_SIZE + 1;
>  	} else {
> -		return RTE_LOGTYPE_PMD;
> +		return sfc_logtype_driver;
>  	}
>  
>  	lt_str = rte_zmalloc("logtype_str", lt_str_size_max, 0);
>  	if (lt_str == NULL)
> -		return RTE_LOGTYPE_PMD;
> +		return sfc_logtype_driver;
>  
>  	strncpy(lt_str, lt_prefix_str, lt_prefix_str_size);
>  	lt_str[lt_prefix_str_size - 1] = '.';
> 

Overall I think it is good idea to remove RTE_LOGTYPE_PMD, but sfc has a few
more usage of it around same manner, as a fallback value if allocating dynamic
one fails.


Andrew,

Can be possible to update this sfc patch to completely eliminate RTE_LOGTYPE_PMD
usage? What do you think?

Thanks,
ferruh