From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 00/13] mbuf: enhancements of mbuf clones Date: Tue, 28 Apr 2015 11:50:20 +0200 Message-ID: <5863036.r8K7YaoNjh@xps13> References: <1429610122-30943-1-git-send-email-olivier.matz@6wind.com> <1429696650-9043-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725821420BD6@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Olivier Matz Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB97725821420BD6-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > The first objective of this series is to fix the support of indirect > > mbufs when the application reserves a private area in mbufs. It also > > removes the limitation that rte_pktmbuf_clone() is only allowed on > > direct (non-cloned) mbufs. The series also contains some enhancements > > and fixes in the mbuf area that makes the implementation of the > > last patches easier. > > > > Changes in v6: > > - restore the priv_size in mbuf structure, version 4 broke the > > attachment between mbufs having different private size > > - add a test case to ensure it won't be broken again > > - replace 0xffff by UINT16_MAX > > - fix some minor checkpatch issues > > > > Changes in v5: > > - update rte_mbuf_version.map to fix compilation with shared libraries > > > > Changes in v4: > > - do not add a priv_size in mbuf structure, having a proper accessor > > to read it from the pool private area is clearer > > - prepend some reworks in the mbuf area to simplify the implementation > > (fix mbuf initialization by not using a hardcoded mbuf size, add > > accessors for mbuf pool private area, add a helper to create a > > mbuf pool) > > > > Changes in v3: > > - a mbuf can now attach to another one that have a different private > > size. In this case, the m->priv_size corresponds to the size of the > > private area of the direct mbuf. > > - add comments to reflect these changes > > - minor style modifications > > > > Changes in v2: > > - do not change the use of MBUF_EXT_MEM() in vhost > > - change rte_mbuf_from_baddr() to rte_mbuf_from_indirect(), removing > > one parameter > > - fix and rework rte_pktmbuf_detach() > > - move m->priv_size in second mbuf cache line > > - fix mbuf free in test error case > > > > Olivier Matz (13): > > mbuf: fix mbuf data room size calculation rte_pktmbuf_pool_init > > examples: always initialize mbuf_pool private area > > mbuf: add accessors to get data room size and private size > > mbuf: fix rte_pktmbuf_init when mbuf private size is not zero > > testpmd: use standard functions to initialize mbufs and mbuf pool > > mbuf: introduce a new helper to create a mbuf pool > > apps: use rte_pktmbuf_pool_create to create mbuf pools > > mbuf: fix clone support when application uses private mbuf data > > mbuf: allow to clone an indirect mbuf > > test/mbuf: rename mc variable in m > > test/mbuf: enhance mbuf refcnt test > > test/mbuf: verify that cloning a clone works properly > > test/mbuf: add a test case for clone with different priv size > > Acked-by: Konstantin Ananyev Applied, thanks