From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] build: add meson support for icc Date: Tue, 26 Feb 2019 18:44:41 +0100 Message-ID: <5876940.G3kBTdO44F@xps> References: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com To: Andrius Sirvys Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 64CAA2C39 for ; Tue, 26 Feb 2019 18:44:44 +0100 (CET) In-Reply-To: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/02/2019 15:18, Andrius Sirvys: > When building with mason, checks if the compiler is icc. If they match, > the warning_flags are changed to ensure icc compilation is successful. > > Disabled error 3656: "variable may be used before its value is set" > in librte_telemetry, bnx2x, ixgbe and sfc as they were false positives. > > Signed-off-by: Andrius Sirvys > Tested-by: Ferruh Yigit I'm really not sure about supporting icc. It may be hard to get a license for icc. And it is not available as a simple package. It means we are adding code that the community cannot test. I think we should rely on free compilers only. PS: I'm not even talking about the suspicious verification done by the installers of the suites including icc.