From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 08/10] devargs: make parsing variadic
Date: Sun, 22 Apr 2018 23:52:05 +0200
Message-ID: <5886590.iS5MIAAj3q@xps>
References: <cover.1507796100.git.gaetan.rivet@6wind.com>
 <cover.1521587199.git.gaetan.rivet@6wind.com>
 <7fe49878f2716e3ad1c5cee204d50d5f3c3a2716.1521587199.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 42233200
 for <dev@dpdk.org>; Sun, 22 Apr 2018 23:52:08 +0200 (CEST)
In-Reply-To: <7fe49878f2716e3ad1c5cee204d50d5f3c3a2716.1521587199.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/03/2018 00:20, Gaetan Rivet:
>  /**
>   * Add a device to the user device list
>   *
> - * For PCI devices, the format of arguments string is "PCI_ADDR" or
> - * "PCI_ADDR,key=val,key2=val2,...". Examples: "08:00.1", "0000:5:00.0",
> - * "04:00.0,arg=val".
> + * The format is
>   *
> - * For virtual devices, the format of arguments string is "DRIVER_NAME*"
> - * or "DRIVER_NAME*,key=val,key2=val2,...". Examples: "net_ring",
> - * "net_ring0", "net_pmdAnything,arg=0:arg2=1". The validity of the
> - * driver name is not checked by this function, it is done when probing
> - * the drivers.
> + *     bus:device_identifier,arg1=val1,arg2=val2
> + *
> + * Examples:
> + *
> + *     pci:0000:05.00.0,arg=val
> + *     vdev:net_ring0

I think this part should not be in the patch.
Or I miss something?