From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Roy Fan" Subject: Re: [PATCH] examples/l2fwd-crypto: fix incorrect padding addition Date: Thu, 9 Feb 2017 18:22:51 +0000 Message-ID: <589CB37B.7060404@intel.com> References: <1486643265-244932-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Pablo de Lara , declan.doherty@intel.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AA8EEFAD7 for ; Thu, 9 Feb 2017 19:22:54 +0100 (CET) In-Reply-To: <1486643265-244932-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/02/2017 12:27, Pablo de Lara wrote: > L2fwd-crypto app was padding an incoming buffer, > to be aligned with the algorithm block size, in all cases. > This was not the right approach, as padding is only necessary > when using block cipher algorithms, such as AES-CBC. > In case of using a stream cipher algorithm, such as SNOW3G UEA2, > there is no need to include padding and increase the buffer size. > > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") > > Signed-off-by: Pablo de Lara > Acked-by : Fan Zhang