From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 04/18] net/axgbe: add structures for MAC
 initialization and reset
Date: Fri, 16 Mar 2018 17:43:32 +0000
Message-ID: <58b8cdb2-5822-b580-0b32-d65c068b5eb4@intel.com>
References: <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-4-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id C67675F72
 for <dev@dpdk.org>; Fri, 16 Mar 2018 18:43:34 +0100 (CET)
In-Reply-To: <1520584954-130575-4-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/9/2018 8:42 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> @@ -167,6 +358,106 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
>  	pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
>  	pdata->pci_dev = pci_dev;
>  
> +	pdata->xgmac_regs =
> +		(uint64_t)pci_dev->mem_resource[AXGBE_AXGMAC_BAR].addr;
> +	pdata->xprop_regs = pdata->xgmac_regs + AXGBE_MAC_PROP_OFFSET;
> +	pdata->xi2c_regs = pdata->xgmac_regs + AXGBE_I2C_CTRL_OFFSET;
> +	pdata->xpcs_regs = (uint64_t)pci_dev->mem_resource[AXGBE_XPCS_BAR].addr;
> +
> +	/* version specific driver data*/
> +	if (pci_dev->id.device_id == 0x1458)
> +		pdata->vdata = &axgbe_v2a;
> +	else
> +		pdata->vdata = &axgbe_v2b;

Can replace hardcoded value 0x1458 with define.

<...>