From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v4 1/6] lib: distributor performance
	enhancements
Date: Thu, 19 Jan 2017 14:58:38 +0000
Message-ID: <58d98518-7204-32d7-f0b7-c459a5be70fb@intel.com>
References: <1482381428-148094-2-git-send-email-david.hunt@intel.com>
 <1483948248-91364-1-git-send-email-david.hunt@intel.com>
 <1483948248-91364-2-git-send-email-david.hunt@intel.com>
 <20170113151955.GA201464@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 72A4CFA31
 for <dev@dpdk.org>; Thu, 19 Jan 2017 15:58:49 +0100 (CET)
In-Reply-To: <20170113151955.GA201464@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 13/1/2017 3:19 PM, Bruce Richardson wrote:
> On Mon, Jan 09, 2017 at 07:50:43AM +0000, David Hunt wrote:
>> Now sends bursts of up to 8 mbufs to each worker, and tracks
>> the in-flight flow-ids (atomic scheduling)
>>
>> New file with a new api, similar to the old API except with _burst
>> at the end of the function names
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>>   lib/librte_distributor/Makefile                    |   2 +
>>   lib/librte_distributor/rte_distributor.c           |  72 +--
>>   lib/librte_distributor/rte_distributor_burst.c     | 558 +++++++++++++++++++++
>>   lib/librte_distributor/rte_distributor_burst.h     | 255 ++++++++++
>>   lib/librte_distributor/rte_distributor_priv.h      | 189 +++++++
>>   lib/librte_distributor/rte_distributor_version.map |   9 +
>>   6 files changed, 1014 insertions(+), 71 deletions(-)
>>   create mode 100644 lib/librte_distributor/rte_distributor_burst.c
>>   create mode 100644 lib/librte_distributor/rte_distributor_burst.h
>>   create mode 100644 lib/librte_distributor/rte_distributor_priv.h
>>
> Run a documentation sanity check after this patch throws up a few
> warnings:
>
> --- /dev/null   2017-01-10 10:26:01.206201474 +0000
> +++ /tmp/doc-check/doc.txt      2017-01-13 15:19:50.717102848 +0000
> @@ -0,0 +1,6 @@
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:187:
> warning: argument 'mbuf' of command @param is not found in the argument
> list of rte_distributor_return_pkt_burst(struct rte_distributor_burst
> *d, unsigned int worker_id, struct rte_mbuf **oldpkt, int num)
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:199:
> warning: The following parameters of
> rte_distributor_return_pkt_burst(struct rte_distributor_burst *d,
> unsigned int worker_id, struct rte_mbuf **oldpkt, int num) are not
> documented:
> +  parameter 'oldpkt'
> +  parameter 'num'
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73:
> warning: Found unknown command `\in_flight_bitmask'
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73:
> warning: Found unknown command `\rte_distributor_process'
>
> Regards,
> /Bruce

Will be cleaned up in next revsion.

Thanks,
Dave.