From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v8 09/10] eal: replace rte_panic instances in
 init sequence
Date: Wed, 25 Apr 2018 14:53:07 +0100
Message-ID: <590fdef8-8788-5a06-7bef-29622c1266eb@intel.com>
References: <1524608213-2080-1-git-send-email-arnon@qwilt.com>
 <1524663944-30376-1-git-send-email-arnon@qwilt.com>
 <1524663944-30376-10-git-send-email-arnon@qwilt.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>, thomas@monjalon.net,
 wenzhuo.lu@intel.com, declan.doherty@intel.com,
 jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
 ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AD10C69F7
 for <dev@dpdk.org>; Wed, 25 Apr 2018 15:53:12 +0200 (CEST)
In-Reply-To: <1524663944-30376-10-git-send-email-arnon@qwilt.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 25-Apr-18 2:45 PM, Arnon Warshavsky wrote:
> Change some local functions return type from void to int.
> This change does not break ABI as the functions are internal.
> Panic thrown from threads was not handled in this patch
> 
> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
> ---

<...>

>   	retval = fcntl(mem_cfg_fd, F_SETLK, &wr_lock);
>   	if (retval < 0){
>   		close(mem_cfg_fd);
> -		rte_exit(EXIT_FAILURE, "Cannot create lock on '%s'. Is another primary "
> -				"process running?\n", pathname);
> +		mem_cfg_fd = -1;
> +		RTE_LOG(CRIT, EAL, "%s(): Cannot create lock on '%s'. Is another primary process running?\n",
> +				__func__, pathname);
> +		return -1;
>   	}
>   
>   	rte_mem_cfg_addr = mmap(NULL, sizeof(*rte_config.mem_config),
>   				PROT_READ | PROT_WRITE, MAP_SHARED, mem_cfg_fd, 0);
>   
>   	if (rte_mem_cfg_addr == MAP_FAILED){
> -		rte_panic("Cannot mmap memory for rte_config\n");
> +		RTE_LOG(CRIT, EAL, "%s(): Cannot mmap memory for rte_config\n",
> +				__func__);
> +		return -1;

Still missing mem_cfg_fd close() and set to -1 here.

Once this is fixed,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

And please keep my ack this time :)

-- 
Thanks,
Anatoly