From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 1/8] stack: introduce rte stack library
Date: Wed, 03 Apr 2019 19:06:24 +0200
Message-ID: <5912114.tna7mvfDTn@xps>
References: <20190401001238.17625-1-gage.eads@intel.com>
 <20190401211429.20282-2-gage.eads@intel.com>
 <VE1PR08MB514938E119122A658967563498560@VE1PR08MB5149.eurprd08.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
 "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>
To: Gage Eads <gage.eads@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 09C8F1B4F6
 for <dev@dpdk.org>; Wed,  3 Apr 2019 19:06:28 +0200 (CEST)
In-Reply-To: <VE1PR08MB514938E119122A658967563498560@VE1PR08MB5149.eurprd08.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/04/2019 13:14, Honnappa Nagarahalli:
> > Subject: [PATCH v6 1/8] stack: introduce rte stack library
> > 
> > The rte_stack library provides an API for configuration and use of a bounded
> > stack of pointers. Push and pop operations are MT-safe, allowing concurrent
> > access, and the interface supports pushing and popping multiple pointers at a
> > time.
> > 
> > The library's interface is modeled after another DPDK data structure, rte_ring,
> > and its lock-based implementation is derived from the stack mempool
> > handler. An upcoming commit will migrate the stack mempool handler to
> > rte_stack.
> > 
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

It does not compile for Arm:

lib/librte_stack/rte_stack_std.h:
	In function '__rte_stack_std_pop':
lib/librte_stack/rte_stack_std.h:68:6: error:
	implicit declaration of function 'unlikely'