public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Subject: Re: [PATCH] eal/linux: fix HPET symbols export
Date: Fri, 27 Feb 2026 16:34:24 +0800	[thread overview]
Message-ID: <59136df4-304b-422a-9c64-62b76060ceea@huawei.com> (raw)
In-Reply-To: <20260218101859.3028581-1-david.marchand@redhat.com>

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2/18/2026 6:18 PM, David Marchand wrote:
> The .map generation script has no clue about build configuration as it
> relies only on the presence of RTE_EXPORT* and RTE_VERSION* markers in
> a source file.
> 
> As a consequence, Linux eal_exports.map contains references to
> HPET symbols regardless of the use_hpet meson option value.
> 
> $ meson configure build -Duse_hpet=false
> $ ninja -C build
> ...
> $ grep hpet build/lib/eal_exports.map
> 	rte_eal_hpet_init;
> 	rte_get_hpet_cycles;
> 	rte_get_hpet_hz;
> 
> As far as I have seen, superfluous exports have no impact on generating
> a shared library with the GNU linker, yet it might be different with
> other linkers (MSVC linker would complain, for example).
> 
> Moving those symbols to a dedicated source file solves this (non?) issue.
> 
> Fixes: 57c194d142d9 ("build: use dynamically generated version maps")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>


  parent reply	other threads:[~2026-02-27  8:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 10:18 [PATCH] eal/linux: fix HPET symbols export David Marchand
2026-02-19  8:19 ` David Marchand
2026-02-27  8:34 ` fengchengwen [this message]
2026-03-05 12:23 ` David Marchand
2026-03-05 13:20   ` Ben Magistro
2026-03-05 13:42     ` David Marchand
2026-03-05 13:50       ` Ben Magistro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59136df4-304b-422a-9c64-62b76060ceea@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox