From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 0/8] Clean up rte_option Date: Tue, 15 Jan 2019 02:23:54 +0100 Message-ID: <5915331.rAsu6mPESc@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Gaetan Rivet Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6AC231B0FF for ; Tue, 15 Jan 2019 02:23:57 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/12/2018 18:06, Gaetan Rivet: > rte_option lib might benefit from a few improvements. > > Overview: > > - list registered options on /rte/app --help > - check duplicates within base EAL options > - rename some fields to be closer to standard struct option > and just cleaner overall. > - fix some strange code (static iterator?) > - fix doc, improve API a little... > > Gaetan Rivet (8): > option: use bare option string as name > option: do not use static iterator > option: add usage string > option: rename name field > option: check against common option on register > option: fix log level of error in register > option: improve library documentation > option: return an error when register fail Several weeks passed without any comment. Applied, thanks