From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx
	parameters
Date: Sat, 31 Mar 2018 02:01:05 +0200
Message-ID: <5922778.WOJhgh4gTO@xps>
References: <20180321142749.27520-1-remy.horton@intel.com>
 <20180321142749.27520-5-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 745492BF7
 for <dev@dpdk.org>; Sat, 31 Mar 2018 02:01:23 +0200 (CEST)
In-Reply-To: <20180321142749.27520-5-remy.horton@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/03/2018 15:27, Remy Horton:
>  /*
>   * Configurable number of RX/TX ring descriptors.

Configurable, really?

> + * Defaults are supplied by drivers via ethdev.

And fallback values are in ethdev.

>   */
> -#define RTE_TEST_RX_DESC_DEFAULT 1024
> -#define RTE_TEST_TX_DESC_DEFAULT 1024
> +#define RTE_TEST_RX_DESC_DEFAULT 0
> +#define RTE_TEST_TX_DESC_DEFAULT 0

We do not need a define for 0.
Better to rework a bit above and below comments.

>  uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */
>  uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */

These doxygen comments in the middle of the code are totally useless.