From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vhost: postpone ring addresses translations at kick time only Date: Tue, 07 Nov 2017 02:28:09 +0100 Message-ID: <5924423.GFTsNyYVQg@xps> References: <20171103155235.29869-1-maxime.coquelin@redhat.com> <20171106115852.GD12931@yliu-home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Yuanhan Liu , lei.a.yao@intel.com, mst@redhat.com To: Maxime Coquelin Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 72AB51B388 for ; Tue, 7 Nov 2017 02:28:11 +0100 (CET) In-Reply-To: <20171106115852.GD12931@yliu-home> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/11/2017 12:58, Yuanhan Liu: > On Fri, Nov 03, 2017 at 04:52:35PM +0100, Maxime Coquelin wrote: > > If multiple queue pairs are created but all are not used, the > > device is never started, as unused queues aren't enabled and > > their ring addresses aren't translated. The device is changed > > to running state when all rings addresses are translated. > > > > This patch fixes this by postponning rings addresses translation > > at kick time unconditionnaly, VHOST_USER_F_PROTOCOL_FEATURES > > being negotiated or not. > > > > Reported-by: Lei Yao > > Signed-off-by: Maxime Coquelin > > Acked-by: Yuanhan Liu Applied, thanks