From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akhil Goyal Subject: Re: [PATCH] doc: announce ABI change for cryptodev and ethdev Date: Tue, 8 Aug 2017 12:24:39 +0530 Message-ID: <59307fef-7741-ef82-a646-fa952ab9d54d@nxp.com> References: <20170803153211.23073-1-akhil.goyal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nicolau, Radu" , "aviadye@mellanox.com" , "borisp@mellanox.com" , "hemant.agrawal@nxp.com" , Thomas Monjalon , "dev@dpdk.org" To: "De Lara Guarch, Pablo" , Declan Doherty Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0056.outbound.protection.outlook.com [104.47.36.56]) by dpdk.org (Postfix) with ESMTP id A2D112B9D for ; Tue, 8 Aug 2017 08:54:55 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo/Declan, On 8/4/2017 8:55 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Thursday, August 3, 2017 4:32 PM >> To: dev@dpdk.org; Doherty, Declan ; >> thomas@monjalon.net; Nicolau, Radu ; >> aviadye@mellanox.com; borisp@mellanox.com; >> hemant.agrawal@nxp.com; De Lara Guarch, Pablo >> >> Cc: Akhil Goyal >> Subject: [PATCH] doc: announce ABI change for cryptodev and ethdev >> >> Support for security operations is planned to be added in ethdev and >> cryptodev for the 17.11 release. >> >> For this following changes are required. >> - rte_cryptodev and rte_eth_dev structures need to be added new >> parameter rte_security_ops which extend support for security ops to the >> corresponding driver. >> - rte_cryptodev_info and rte_ethd_dev_info need to be added with >> rte_security_capabilities to identify the capabilities of the corresponding >> driver. >> >> Signed-off-by: Akhil Goyal > > Not sure if this needed to be split into two patches, as this affects two libraries. > At least, from cryptodev side: > > Acked-by: Pablo de Lara > We would be needing one more ABI change, Can I send it now. I discovered it after I sent this patch. In the struct rte_crypto_sym_op, we would need to add a pointer to a security session in the union of session and xform. Also, Do I need to split this patch into two for crypto and eth? Regards, Akhil