From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 05/14] ethdev: Add rte_eth_dev_free to free specified device Date: Tue, 17 Feb 2015 01:46:29 +0100 Message-ID: <5935372.TlW161azlx@xps13> References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <1424060073-23484-1-git-send-email-mukawa@igel.co.jp> <1424060073-23484-6-git-send-email-mukawa@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Tetsuya Mukawa Return-path: In-Reply-To: <1424060073-23484-6-git-send-email-mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-16 13:14, Tetsuya Mukawa: > This patch adds rte_eth_dev_free(). The function is used for changing an > attached status of the device that has specified name. > > v6: > - Use rte_eth_dev structure as the paramter of rte_eth_dev_free(). > v4: > - Add parameter checking. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_ether/rte_ethdev.c | 11 +++++++++++ > lib/librte_ether/rte_ethdev.h | 14 ++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index a79fa5b..2463d18 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -260,6 +260,17 @@ rte_eth_dev_allocate(const char *name) > return eth_dev; > } > > +int > +rte_eth_dev_free(struct rte_eth_dev *eth_dev) > +{ > + if (eth_dev == NULL) > + return -EINVAL; > + > + eth_dev->attached = 0; > + nb_ports--; > + return 0; > +} This function is strange. I would imagine it calling the free (uninit) function of the driver. [...] > +/** > + * Function for internal use by dummy drivers primarily, e.g. ring-based > + * driver. > + * Free the specified ethdev. > + * > + * @param eth_dev > + * The *eth_dev* pointer is the address of the *rte_eth_dev* structure > + * associated with the matching device and which have been [automatically] > + * allocated in the *rte_eth_devices* array. > + * @return > + * - 0 on success, negative on error > + */ > +int rte_eth_dev_free(struct rte_eth_dev *eth_dev); > + > struct eth_driver; > /** > * @internal >