From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] hash: Correctly set the compare function.
Date: Thu, 22 Sep 2016 17:42:55 +0200
Message-ID: <5960468.PdAfGihvNv@xps13>
References: <1474105404-27654-1-git-send-email-masoudhasanifard@gmail.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Masoud Hasanifard <masoudhasanifard@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 1600F2B96
 for <dev@dpdk.org>; Thu, 22 Sep 2016 17:42:57 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id l132so335069245wmf.0
 for <dev@dpdk.org>; Thu, 22 Sep 2016 08:42:57 -0700 (PDT)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-19 18:36, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Masoud
> Commit titles start with lowercase ("correctly") and without a dot at the end.
> > 
> > Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the
> > custom
> > function we are setting in rte_hash_set_cmp_func properly works. The
> > custom
> > function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to
> > KEY_CUSTOM.
> 
> I think this is a fix, so probably it should contain the following "Fixes" line in the commit message:
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
[...]
> Good catch! Two comments inline.

Applied, thanks