From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4] net/mlx5: load libmlx5 and libibverbs in
	run-time
Date: Thu, 04 Jan 2018 18:30:42 +0100
Message-ID: <5995459.c5JPvxqq0z@xps>
References: <37757d5cfe32610ef1c7a17d72ea6bc1466023de.1511450393.git.shacharbe@mellanox.com>
 <AM6PR0502MB3640E01C6BF5F46C278C7236C01E0@AM6PR0502MB3640.eurprd05.prod.outlook.com>
 <20180104073608.bxyv6d5vzb7z4izz@shalom>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shachar Beiser <shacharbe@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 955917D30
 for <dev@dpdk.org>; Thu,  4 Jan 2018 18:31:02 +0100 (CET)
In-Reply-To: <20180104073608.bxyv6d5vzb7z4izz@shalom>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/01/2018 08:36, N=E9lio Laranjeiro:
> Hi Shachar,
>=20
> On Wed, Jan 03, 2018 at 03:00:46PM +0000, Shachar Beiser wrote:
> <snip/>
> > > > --- a/config/common_base
> > > > +++ b/config/common_base
> > > > @@ -236,6 +236,7 @@ CONFIG_RTE_LIBRTE_MLX4_TX_MP_CACHE=3D8
> > > >  # Compile burst-oriented Mellanox ConnectX-4 & ConnectX-5 (MLX5) P=
MD
> > > > #  CONFIG_RTE_LIBRTE_MLX5_PMD=3Dn
> > > > +CONFIG_RTE_LIBRTE_MLX5_DLL=3Dy
> > > >  CONFIG_RTE_LIBRTE_MLX5_DEBUG=3Dn
> > > >  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=3D8
> > >=20
> > > Not sure a new configuration item is allowed.  If it is, the document=
ation of
> > > such variable is missing.
> >=20
> > [S.B] The patch is based on this CONFIG_RTE_LIBRTE_MLX5_DLL , it was
> > required by Adrian in the design phase to enable/disable this linkage
> > mode.
> >           I will update the documentation .
>=20
> Before updating the documentation you should speak with Thomas or
> Ferruh, not sure new items are allowed anymore.

It is OK to add a compilation option to configure the compilation.