From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 02/19] drivers: create drivers and
 drivers/net directory
Date: Wed, 20 May 2015 15:30:40 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0345399F8@IRSMSX103.ger.corp.intel.com>
References: <1431450315-13179-1-git-send-email-bruce.richardson@intel.com>
 <1431705423-16134-1-git-send-email-bruce.richardson@intel.com>
 <1431705423-16134-3-git-send-email-bruce.richardson@intel.com>
 <5822237.JRlZbxOZb6@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 29CFC5698
 for <dev@dpdk.org>; Wed, 20 May 2015 17:30:46 +0200 (CEST)
In-Reply-To: <5822237.JRlZbxOZb6@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, May 20, 2015 4:05 PM
> To: Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 02/19] drivers: create drivers and
> drivers/net directory
>=20
> 2015-05-15 16:56, Bruce Richardson:
> > Add a new top-level "drivers" directory to which all PMDs will be
> > moved for easier maintenance of both lib folder and drivers
> > themselves. This new directory is a dependency of all the apps in the
> > app folder, so the makefiles for each app are updated.
>=20
> Why drivers are a dependency of every apps?
> Some of them don't even include rte_ethdev.h.

Good point. I just got a broken build initially in the apps with missing de=
pendencies, so I made the change so that dependencies were the same as befo=
re.

Looking at things, I imagine test-pmd and test-pipeline depend upon the dri=
vers since they do packet IO, and the test app will depend on it as it has =
unit tests for the bond-ethdev driver.
Dump-cfg and the test-acl app should not have a dependency on the driver, I=
 imagine.=20

It appears that the cmdline-test app is missing a DEPDIRS-y line, but it pr=
obably should depend on the libs, right?

/Bruce