From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH v5 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params Date: Mon, 4 Jul 2016 11:39:51 +0100 Message-ID: <59d3c9d1-2c56-53b4-ff38-ab42ace12552@intel.com> References: <1466688410-13826-1-git-send-email-zr@semihalf.com> <1467615087-20510-1-git-send-email-zr@semihalf.com> <1467615087-20510-2-git-send-email-zr@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Zyta Szpak , thomas.monjalon@6wind.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jerin.jacob@caviumnetworks.com, rahul.lakkireddy@chelsio.com Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2CF082B9C for ; Mon, 4 Jul 2016 12:39:55 +0200 (CEST) In-Reply-To: <1467615087-20510-2-git-send-email-zr@semihalf.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/07/2016 07:51, Zyta Szpak wrote: > From: Zyta Szpak > > Version 4 of fixing the fixed register width assumption. > The app was allocating too little space for 64-bit registers > which resulted in memory corruption. This commit resolves > this by getting the number of registers and size of register > by rte_eth_dev_get_reg_info function called first time > with data=NULL. Comments regarding commit message on v4 1/2 also apply here.. It is also not v4.. :) > Signed-off-by: Zyta Szpak > --- > examples/ethtool/lib/rte_ethtool.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-)