DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>,
	Ray Kinsella <mdr@ashroe.eu>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [PATCH v4 2/8] interrupts: fix event arrays copy on instance duplication
Date: Fri, 23 Oct 2026 16:55:03 +0200	[thread overview]
Message-ID: <59ed6f21-befd-4ad8-81e0-c5257ec389c3@intel.com> (raw)
In-Reply-To: <CAJFAV8ypGhAUU_XvFrxe9nMrxCWXwRmYL6sqzPjT0UKrYQLw1g@mail.gmail.com>

On 10/23/2026 4:44 PM, David Marchand wrote:
> On Fri, 23 Oct 2026 at 16:37, Burakov, Anatoly
> <anatoly.burakov@intel.com> wrote:
>>
>> On 10/23/2026 4:15 PM, David Marchand wrote:
>>> On Fri, 23 Oct 2026 at 15:51, Anatoly Burakov <anatoly.burakov@intel.com> wrote:
>>>>
>>>> The event FD and epoll event arrays are copied using the number of
>>>> entries as a byte count, so only a fraction of the entries make it
>>>> into the duplicate.
>>>>
>>>> Copy the arrays by element size.
>>>>
>>>> Fixes: b7c984291611 ("interrupts: add allocator and accessors")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>>
>>> Thanks for working on those issues on such short notice.
>>>
>>> I already put a series for fixing a number of issues with interrupts.
>>> As part of it, I would remove the whole duplication principle.
>>>
>>> Could you perhaps test your series on top of mine?
>>>
>>> https://patchwork.dpdk.org/project/dpdk/list/?series=39749
>>>
>>>
>>
>> It seems that your patchset makes most of mine obsolete, as only 3
>> commits survived the rebase (incidentally, the ones I had in v2), and
>> the conflicts were trivial enough to resolve on apply IMO. If you like I
> 
> Indeed.
> 
>> can rebase my patchset on top of yours so that you may include it in
>> yours and take over?
> 
> I don't mind taking over.
> We just need to agree on my comment on the last patch.
> 
> The other two fixes lgtm.
> 

I added my comment to the last patch, so feel free to take over the patches!

-- 
Thanks,
Anatoly

  reply	other threads:[~2026-10-23 14:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23  9:36 [PATCH v1 1/1] eal/linux: fix eventfd leaks when enabling interrupts Anatoly Burakov
2026-10-23 11:42 ` David Marchand
2026-10-23 12:25   ` Burakov, Anatoly
2026-10-23 13:07 ` [PATCH v2 1/3] eal/linux: fix closing of event FDs not owned by EAL Anatoly Burakov
2026-10-23 13:07   ` [PATCH v2 2/3] interrupts: warn on leaked event FDs Anatoly Burakov
2026-10-23 13:07   ` [PATCH v2 3/3] eal/linux: fix eventfd leaks when enabling interrupts Anatoly Burakov
2026-10-23 13:39 ` [PATCH v3 1/8] interrupts: fix size of duplicated instance Anatoly Burakov
2026-10-23 13:39   ` [PATCH v3 2/8] interrupts: fix event arrays copy on instance duplication Anatoly Burakov
2026-10-23 13:39   ` [PATCH v3 3/8] eal/linux: fix closing of event FDs not owned by EAL Anatoly Burakov
2026-10-23 13:39   ` [PATCH v3 4/8] eal/linux: fix eventfd leaks when enabling interrupts Anatoly Burakov
2026-10-23 13:39   ` [PATCH v3 5/8] eal/linux: fix leaked FD warnings for interrupt sources Anatoly Burakov
2026-10-23 13:39   ` [PATCH v3 6/8] eal/freebsd: fix interrupt source handle leak Anatoly Burakov
2026-10-23 13:39   ` [PATCH v3 7/8] bus/pci: fix leaked device FD warning on VFIO unmap Anatoly Burakov
2026-10-23 13:49     ` Burakov, Anatoly
2026-10-23 13:39   ` [PATCH v3 8/8] interrupts: warn on leaked event FDs Anatoly Burakov
2026-10-23 13:51 ` [PATCH v4 1/8] interrupts: fix size of duplicated instance Anatoly Burakov
2026-10-23 13:51   ` [PATCH v4 2/8] interrupts: fix event arrays copy on instance duplication Anatoly Burakov
2026-10-23 14:15     ` David Marchand
2026-10-23 14:36       ` Burakov, Anatoly
2026-10-23 14:44         ` David Marchand
2026-10-23 14:55           ` Burakov, Anatoly [this message]
2026-10-23 13:51   ` [PATCH v4 3/8] eal/linux: fix closing of event FDs not owned by EAL Anatoly Burakov
2026-10-23 14:17     ` David Marchand
2026-10-23 13:51   ` [PATCH v4 4/8] eal/linux: fix eventfd leaks when enabling interrupts Anatoly Burakov
2026-10-23 14:37     ` David Marchand
2026-10-23 13:51   ` [PATCH v4 5/8] eal/linux: fix leaked FD warnings for interrupt sources Anatoly Burakov
2026-10-23 13:51   ` [PATCH v4 6/8] eal/freebsd: fix interrupt source handle leak Anatoly Burakov
2026-10-23 13:51   ` [PATCH v4 7/8] bus/pci: fix leaked device FD warning on VFIO unmap Anatoly Burakov
2026-10-23 13:51   ` [PATCH v4 8/8] interrupts: warn on leaked event FDs Anatoly Burakov
2026-10-23 14:41     ` David Marchand
2026-10-23 14:48       ` Burakov, Anatoly
2026-10-24  8:56         ` David Marchand
2026-10-24  9:57           ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59ed6f21-befd-4ad8-81e0-c5257ec389c3@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=hkalra@marvell.com \
    --cc=mdr@ashroe.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox