From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH] net/i40e: fix missing Port Representor data-path callbacks Date: Fri, 11 May 2018 13:29:04 +0100 Message-ID: <5a4dea92-18db-2e4a-7ae5-3fadd0720137@intel.com> References: <20180509150005.2531-1-remy.horton@intel.com> <91b7ee64-fbd0-0b6a-28ad-41906f414733@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Qi Zhang , Beilei Xing , Ferruh Yigit To: Mohammad Abdul Awal , dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CACF31C4A9 for ; Fri, 11 May 2018 14:29:07 +0200 (CEST) In-Reply-To: <91b7ee64-fbd0-0b6a-28ad-41906f414733@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/05/2018 11:48, Mohammad Abdul Awal wrote: [..] >> +static uint16_t >> +i40e_vf_representor_tx_burst(__rte_unused void *tx_queue, >> + struct rte_mbuf **tx_pkts, >> + uint16_t nb_pkts) >> +{ >> + uint16_t idx_pkt; >> + >> + for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++) >> + rte_pktmbuf_free(tx_pkts[idx_pkt]); > We should not free them in the driver silently whereas the application > will think that it has been sent successfully. > Please use the same rule for rx_burst, and return 0. Ok, v2 coming. I'll also combine this and the ixgbe patch into the same patchset.