From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5] ethdev: add flow API to expand RSS flows
Date: Fri, 29 Jun 2018 17:23:33 +0100
Message-ID: <5ae59430-1488-abb4-fdee-0f773d0010ab@intel.com>
References: <20180627145525.8659-1-nelio.laranjeiro@6wind.com>
 <2b29e115e43f519e2cc2fa1a075849f53c7bf92a.1530201647.git.nelio.laranjeiro@6wind.com>
 <20180628160927.GI4025@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 7C0041B5E1
 for <dev@dpdk.org>; Fri, 29 Jun 2018 18:23:36 +0200 (CEST)
In-Reply-To: <20180628160927.GI4025@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/28/2018 5:09 PM, Adrien Mazarguil wrote:
> On Thu, Jun 28, 2018 at 06:01:21PM +0200, Nelio Laranjeiro wrote:
>> Introduce an helper for PMD to expand easily flows items list with RSS
>> action into multiple flow items lists with priority information.
>>
>> For instance a user items list being "eth / end" with rss action types
>> "ipv4-udp ipv6-udp end" needs to be expanded into three items lists:
>>
>>  - eth
>>  - eth / ipv4 / udp
>>  - eth / ipv6 / udp
>>
>> to match the user request.  Some drivers are unable to reach such
>> request without this expansion, this API is there to help those.
>> Only PMD should use such API for their internal cooking, the application
>> will still handle a single flow.
>>
>> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>> ---
>>
>> Changes in v5:
>>
>> - Replace the struct rte_flow_expand_rss field by a flexible array,
>> - Address all nits.
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> With just a couple of tiny nits, not sure they're worth a v6. See below.
> 
> <snip>
>> +/** Node object of input graph for rte_flow_expand_rss(). */
>> +struct rte_flow_expand_node {
>> +	const int *const next;
>> +	/**< List of next node indexes. Index 0 is interpreted as a
>> +	 * terminator. */
>> +	const enum rte_flow_item_type type;
>> +	/**< Pattern item type of current node. */
>> +	uint64_t rss_types;
>> +	/**< RSS types bit-field associated with this node (see ETH_RSS_*
>> +	 * definitions).*/
>> +};
> 
> Multi-line comments should have opening and closing tokens on dedicated
> lines.
> 
> <snip>
>> + * @param[in] graph.
> 
> Extra "."

Extra "." is causing doc warning, will fix it while merging. Also will fix above
multi-line doxygen comment syntax while merging.

>