From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pallavi Kadam Subject: Re: [PATCH v7 7/8] doc: add documentation for windows Date: Mon, 1 Apr 2019 18:01:04 -0700 Message-ID: <5ae88ef9-e353-c106-683e-94ae90c83ce4@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-8-anand.rawat@intel.com> <111013680.KhI2ai8QQM@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com To: Thomas Monjalon , Anand Rawat Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D23DE4C8F for ; Tue, 2 Apr 2019 03:01:05 +0200 (CEST) In-Reply-To: <111013680.KhI2ai8QQM@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/2019 4:22 PM, Thomas Monjalon wrote: > 29/03/2019 00:24, Anand Rawat: >> Added documentation to build helloworld example >> on windows using meson and clang. Updated the >> maintainers list to include windows maintainers. > [...] >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> +Windows support >> +M: Harini Ramakrishnan >> +M: Omar Cardona >> +M: Anand Rawat >> +M: Ranjit Menon >> +F: lib/librte_eal/windows/ > This change should be in the first patch (when introducing eal/windows). > In this doc patch, you should add > F: doc/guides/windows_gsg/ Ok, will be done in the coming patch v8. > > [...] >> +The DPDK and its applications require the Clang-LLVM* C compiler and MSVC* linker. >> +The Meson* Build system is used to prepare the sources for compilation with the Ninja backend. >> + >> +\*Other names and brands may be claimed as the property of others. > This sentence looks weird. What does it mean? Thought of adding asterisk in front of names and brands those are claimed from other websites/ organizations for instance, MSFT, LLVM. Can be removed, if not required. > > [...] >> +Download and install the clang compiler from `LLVM* website `_. > Why is there an asterisk after LLVM? As the link has been copied from LLVM website (other property). Can be removed, if not required. > > [...] >> +Download and install the Build Tools for Visual Studio to link and build the files on windows, from `Microsoft* website `_. >> +When installing build tools, select the "Visual C++ build tools" option and ensure the Windows SDK is selected. > Please try to limit the line length. > We are supposed to not exceed 80-chars if possible. > The best is to wrap lines logically (as in code) > after a comma or a point, etc. Will limit the line length in v8. > > [...] >> + cd C:\Users\me\dpdk\build >> + helloworld.exe >> + hello from core 1 >> + hello from core 3 >> + hello from core 0 >> + hello from core 2 > That's definitely a good goal for release 19.05! > >> +Limitations >> +=========== >> + >> +DPDK for Windows is currently a work in progress. Not all DPDK source files >> +compile. Support is being added in pieces so as to limit the overall scope >> +of any individual patch series. The goal is to be able to run any DPDK >> +application natively on Windows. > Yes > >