From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 25/41] net/dpaa: add support for Tx and Rx
	queue setup
Date: Mon, 18 Sep 2017 15:55:04 +0100
Message-ID: <5b28593b-5d6c-f77a-80a2-9e8332820b8e@intel.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-26-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 9C7C51B19F
 for <dev@dpdk.org>; Mon, 18 Sep 2017 16:55:09 +0200 (CEST)
In-Reply-To: <20170909112132.13936-26-shreyansh.jain@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> +	for (loop = 0; loop < num_cores; loop++) {
> +		ret = dpaa_tx_queue_init(&dpaa_intf->tx_queues[loop],
> +					 fman_intf);
> +		if (ret)
> +			return ret;
> +		dpaa_intf->tx_queues[loop].dpaa_intf = dpaa_intf;
> +	}
> +	dpaa_intf->nb_tx_queues = num_cores;

Is number of the tx_queues always same as core count?

> +
> +	DPAA_PMD_DEBUG("All frame queues created");
> +
> +	/* reset bpool list, initialize bpool dynamically */
> +	list_for_each_entry_safe(bp, tmp_bp, &cfg->fman_if->bpool_list, node) {
> +		list_del(&bp->node);
> +		rte_free(bp);

Why freeing them during initialization ?

> +	}
> +
> +	/* Populate ethdev structure */
>  	eth_dev->dev_ops = &dpaa_devops;
> +	eth_dev->rx_pkt_burst = dpaa_eth_queue_rx;
> +	eth_dev->tx_pkt_burst = dpaa_eth_tx_drop_all;
> +
> +	/* Allocate memory for storing MAC addresses */
> +	eth_dev->data->mac_addrs = rte_zmalloc("mac_addr",
> +		ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER, 0);
> +	if (eth_dev->data->mac_addrs == NULL) {
> +		DPAA_PMD_ERR("Failed to allocate %d bytes needed to "
> +						"store MAC addresses",
> +				ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER);

free dpaa_intf->rx_queues, tx_queues ?

> +		return -ENOMEM;
> +	}
> +
> +	/* copy the primary mac address */
> +	memcpy(eth_dev->data->mac_addrs[0].addr_bytes,
> +		fman_intf->mac_addr.addr_bytes,
> +		ETHER_ADDR_LEN);

Instead can use ether_addr_copy() instead.

<...>