From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 34/34] net/ice: support meson build
Date: Fri, 14 Dec 2018 08:47:44 +0000
Message-ID: <5b475d27-40f7-7d16-f04f-a1d4af6e478d@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com>
 <1544598004-27099-35-git-send-email-wenzhuo.lu@intel.com>
 <0260ab4a-6c7e-492d-519f-20975750986c@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093FE13F8D@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 472BD1B936
 for <dev@dpdk.org>; Fri, 14 Dec 2018 09:47:47 +0100 (CET)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093FE13F8D@shsmsx102.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/14/2018 2:38 AM, Lu, Wenzhuo wrote:
<...>

>>> @@ -0,0 +1,30 @@
>>> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel
>>> +Corporation
>>> +
>>> +sources = [
>>> +	'ice_controlq.c',
>>> +	'ice_common.c',
>>> +	'ice_sched.c',
>>> +	'ice_switch.c',
>>> +	'ice_nvm.c',
>>
>> ice_dcb.c? It is in base folder, isn't is compiled?
> Currently we don’t use it. Just leave it uncompiled.

Why not remove it now, and add back when used?