From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] drivers: advertise kmod dependencies in
 pmdinfo
Date: Mon, 19 Sep 2016 14:25:53 +0200
Message-ID: <5b6baf3d-58a4-8546-e5ba-bd9514d4019d@6wind.com>
References: <1472217646-26219-1-git-send-email-olivier.matz@6wind.com>
 <1473949355-6787-1-git-send-email-olivier.matz@6wind.com>
 <CALwxeUvaV2zhAxgLabCx3mF_ftfSPgSXRy8fzCdktPDWngTuJA@mail.gmail.com>
 <20160919081726.GA23360@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Neil Horman <nhorman@tuxdriver.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>, vido@cesnet.cz,
 fiona.trahe@intel.com, Stephen Hemminger <stephen@networkplumber.org>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Bruce Richardson <bruce.richardson@intel.com>,
 David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 96C97374F
 for <dev@dpdk.org>; Mon, 19 Sep 2016 14:26:04 +0200 (CEST)
In-Reply-To: <20160919081726.GA23360@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 09/19/2016 10:17 AM, Bruce Richardson wrote:
> On Fri, Sep 16, 2016 at 04:26:35PM +0200, David Marchand wrote:
>> On Thu, Sep 15, 2016 at 4:22 PM, Olivier Matz <olivier.matz@6wind.com> wrote:
>>> Add a new macro DRIVER_REGISTER_KMOD_DEP() that allows a driver to
>>> declare the list of kernel modules required to run properly.
>>>
>>> Today, most PCI drivers require uio/vfio.
>>>
>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>>
>> Thanks Olivier, this looks good to me.
>>
>> Btw, I remember some issues with binding ixgbevf devices to
>> uio_pci_generic, so advertising should be carefully checked for each
>> driver.
> 
> +1 here. In general, uio_pci_generic will not bind to VF devices as VF devices
> don't provide legacy interrupts, which is required to use uio_pci_generic. It's
> not limited to just ixgbevf

Thanks for commenting, I'll remove uio_pci_generic from *vf drivers in
next version.

Olivier