From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4] ethdev: fix MAC address replay Date: Tue, 24 Jan 2017 13:21:39 +0000 Message-ID: <5cd19f6a-311c-b0fe-5d6c-ee757ac2e86e@intel.com> References: <20170123235020.19641-1-jonshin@cisco.com> <20170124022145.7540-1-jonshin@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" , Thomas Monjalon To: Igor Ryzhov , Steve Shin Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id ABE12108D for ; Tue, 24 Jan 2017 14:21:42 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/24/2017 10:09 AM, Igor Ryzhov wrote: > Thank you Steve. > > I never did it before and I don't know if I have rights for that, but: > > Acked-by: Igor Ryzhov > Unrelated to the patch itself, but since it has been mentioned, let me share what I know, I believe Thomas or others will correct me if I am wrong: - Everyone can Ack. And this is useful information for maintainers, so it is something good when more people review and ack. Please do. - Multiple ack or review is better. - But each Ack does not have same weight, maintainer decides on this weight, based on contribution of the person who ack'ed. - There is slight difference between Acked-by and Reviewed-by: -- Acked-by: Kind of asking for patch to be applied, saying this patch is good and please get it. -- Reviewed-by: Saying I have done the review at my best and patch looks good to me. Acked-by has slightly more responsibility than Reviewed-by. If you are not maintainer of that field, and not have strong opinion about that patch to be merged, it is possible to prefer Reviewed-by against Acked-by. But overall both are good, and definitely better than not saying anything at all. Thanks, ferruh > > On Tue, Jan 24, 2017 at 5:21 AM, Steve Shin > wrote: > > This patch fixes a bug in replaying MAC address to the hardware > in rte_eth_dev_config_restore() routine. Added default MAC replay as > well. > > Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements") > > --- > v2: Added default MAC replay & Code optimization > v3: Covered a case (ex, SR-IOV) where multiple pools > exist in the mac_pool_sel array. > v4: removed a coding style warning > > Signed-off-by: Steve Shin > >