From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v2 5/5] mbuf: add user command line config
 mempools ops API
Date: Mon, 15 Jan 2018 20:05:16 +0530
Message-ID: <5d7e0a4f-7007-fa43-80f7-d84e822d8f18@nxp.com>
References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com>
 <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com>
 <1515996674-26338-6-git-send-email-hemant.agrawal@nxp.com>
 <20180115122944.GA833@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <olivier.matz@6wind.com>,
 <santosh.shukla@caviumnetworks.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0084.outbound.protection.outlook.com [104.47.41.84])
 by dpdk.org (Postfix) with ESMTP id 39B7AA56E
 for <dev@dpdk.org>; Mon, 15 Jan 2018 15:35:23 +0100 (CET)
In-Reply-To: <20180115122944.GA833@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/15/2018 5:59 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 15 Jan 2018 11:41:14 +0530
>> From: Hemant Agrawal <hemant.agrawal@nxp.com>

>> This patch add the user command line configured mempool ops name
>> API to librte_mbuf and sends a deprecation notice to remove the
>> similar API from eal.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst |  7 +++++++
>>  lib/librte_mbuf/rte_mbuf.c           |  8 +++++++-
>>  lib/librte_mbuf/rte_mbuf.h           | 10 ++++++++++
>>  lib/librte_mbuf/rte_mbuf_version.map |  1 +
>>  4 files changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 13e8543..ec8018f 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -8,6 +8,13 @@ API and ABI deprecation notices are to be posted here.
>>  Deprecation Notices
>>  -------------------
>>
>> +* eal: a mbuf specific API was part of eal APIs. This is now being
>> +  moved to librte_mbuf to be with other similar APIs.
>> +  The following API is target to be deprecated on 18.05.
>> +
>> +  - ``rte_eal_mbuf_default_mempool_ops`` replaced by
>> +	``rte_mbuf_user_mempool_ops''
>> +
>
> I think, deprecation notice need to be in a separate 'doc" patch.

Yes. you are right.

<snip>..

>> +const char *
>> +rte_mbuf_user_mempool_ops(void)
>> +{
>> +	return internal_config.user_mbuf_pool_ops_name;
>> +}
>> +
>>  /* Return mbuf pool ops name */
>>  static const char *
>>  rte_mbuf_best_mempool_ops(void)
>>  {
>>  	/* User defined mempool ops takes the priority */
>> -	const char *best_ops = rte_eal_mbuf_default_mempool_ops();
>
> I think, we may need to remove the stale rte_eal_mbuf_default_mempool_ops() once
> it is replaced.

Do you mean that till the API is not deprecated, we shall keep the usage?