From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jia He <hejianet@gmail.com>
Subject: Re: [PATCH] ring: guarantee ordering of cons/prod
 loading when doing enqueue/dequeue
Date: Fri, 13 Oct 2017 09:15:54 +0800
Message-ID: <5df4a28b-be1d-d0d8-8148-96f982e212d6@gmail.com>
References: <20171010095636.4507-1-hejianet@gmail.com>
 <20171012155350.j34ddtivxzd27pag@platinum>
 <2601191342CEEE43887BDE71AB9772585FAA859F@IRSMSX103.ger.corp.intel.com>
 <20171012172311.GA8524@jerin>
 <c3517bf8-95f1-0aa4-fc64-47922c35ce1f@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Olivier MATZ <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "jia.he@hxt-semitech.com" <jia.he@hxt-semitech.com>,
 "jie2.liu@hxt-semitech.com" <jie2.liu@hxt-semitech.com>,
 "bing.zhao@hxt-semitech.com" <bing.zhao@hxt-semitech.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com
 [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 271DB1B5E3
 for <dev@dpdk.org>; Fri, 13 Oct 2017 03:16:01 +0200 (CEST)
Received: by mail-pf0-f173.google.com with SMTP id b85so7464260pfj.13
 for <dev@dpdk.org>; Thu, 12 Oct 2017 18:16:01 -0700 (PDT)
In-Reply-To: <c3517bf8-95f1-0aa4-fc64-47922c35ce1f@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 10/13/2017 9:02 AM, Jia He Wrote:
> Hi Jerin
>
>
> On 10/13/2017 1:23 AM, Jerin Jacob Wrote:
>> -----Original Message-----
>>> Date: Thu, 12 Oct 2017 17:05:50 +0000
>>>
[...]
>> On the same lines,
>>
>> Jia He, jie2.liu, bing.zhao,
>>
>> Is this patch based on code review or do you saw this issue on any of 
>> the
>> arm/ppc target? arm64 will have performance impact with this change.
sorry, miss one important information
Our platform is an aarch64 server with 46 cpus.
If we reduced the involved cpu numbers, the bug occurred less frequently.

Yes, mb barrier impact the performance, but correctness is more 
important, isn't it ;-)
Maybe we can  find any other lightweight barrier here?

Cheers,
Jia
> Based on mbuf_autotest, the rte_panic will be invoked in seconds.
>
> PANIC in test_refcnt_iter():
> (lcore=0, iter=0): after 10s only 61 of 64 mbufs left free
> 1: [./test(rte_dump_stack+0x38) [0x58d868]]
> Aborted (core dumped)
>
> Cheers,
> Jia
>>
>>
>>> Konstantin
>