From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH] config: remove useless lines for DPAA2
Date: Tue, 3 Apr 2018 12:25:11 +0530
Message-ID: <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com>
References: <20180402220649.662-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: hemant.agrawal@nxp.com, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr30077.outbound.protection.outlook.com [40.107.3.77])
 by dpdk.org (Postfix) with ESMTP id 0C6E21B66D
 for <dev@dpdk.org>; Tue,  3 Apr 2018 08:40:01 +0200 (CEST)
In-Reply-To: <20180402220649.662-1-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote:
> Some comments are not relevant in a config which only overrides
> the default config.
> 
> The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled
> by default so it can be removed from this file.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>   config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> index ecac994bf..96f478a06 100644
> --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> @@ -9,9 +9,6 @@
>   CONFIG_RTE_MACHINE="dpaa2"
>   CONFIG_RTE_ARCH_ARM_TUNE="cortex-a72"
>   
> -#
> -# Compile Environment Abstraction Layer
> -#
>   CONFIG_RTE_MAX_LCORE=16
>   CONFIG_RTE_MAX_NUMA_NODES=1
>   CONFIG_RTE_CACHE_LINE_SIZE=64
> @@ -22,8 +19,4 @@ CONFIG_RTE_PKTMBUF_HEADROOM=128
>   CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
>   CONFIG_RTE_LIBRTE_VHOST_NUMA=n
>   
> -#
> -# Compile Support Libraries for DPAA2
> -#
>   CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n

I think DEBUG_DRIVER should exist in local config so that a developer 
can easily toggle it without modifying the common_base, which should 
serves as repository rather than toggle.

I do see the problem that having an option in common_base and then 
having it again in local config without overriding (=n) - is non-intuitive.

But, I still feel it is easier to control changes in local config - 
(make T=<local config>) is easily visible.