From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: fix port accessing after release
Date: Fri, 30 Mar 2018 11:40:22 +0100
Message-ID: <5e34c287-be2d-b7f4-91a5-39bf9df828e4@intel.com>
References: <1522239030-24489-1-git-send-email-matan@mellanox.com>
 <1634334.By0c0X4AGY@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, stable@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>, Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1634334.By0c0X4AGY@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/28/2018 1:25 PM, Thomas Monjalon wrote:
> 28/03/2018 14:10, Matan Azrad:
>> rte_eth_dev_pci_release() function wrongly releases an ethdev port and
>> then releases internal fields of this port.
>> This behavior is problematic, because after the release, the port may
>> be reallocated again by another thread or just be invalid for any
>> usage.
>>
>> Move the release operation to the end of the function.
>>
>> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
>> Cc: stable@dpdk.org
>>
>> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/master, thanks.