From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1 0/6] ethdev: add min/max MTU to device info
Date: Tue, 19 Mar 2019 16:30:21 +0000
Message-ID: <5e86db4c-215d-ffea-29ee-df026c894627@intel.com>
References: <1551303948-19746-1-git-send-email-ian.stokes@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: stephen@networkplumber.org, Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <arybchenko@solarflare.com>
To: Ian Stokes <ian.stokes@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id ACAC111A4
 for <dev@dpdk.org>; Tue, 19 Mar 2019 17:30:25 +0100 (CET)
In-Reply-To: <1551303948-19746-1-git-send-email-ian.stokes@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/27/2019 9:45 PM, Ian Stokes wrote:
> Building upon the discussion around [1], this series introduces MTU min
> and MTU max variables. It also provides updates to PMD implementations
> for ixgbe, i40e and IGB devices so that these variables are populated
> for use when retrieving device info.
> 
> This series was tested with OVS DPDK and functions as expected for the
> drivers listed below. But a wider selection of PMD drivers would have to
> adopt this to ensure jumbo frames functionality remains for drivers not
> modified in the series.
> 
> There is also ongoing discussion in [2] regarding overhead to be
> considered with MTU and how this may change from device to device, this
> series uses existing overhead assumptions.
> 
> This series was previously posted as an RFC in [3], this revision
> removes RFC status and implements changes received in feedback.
> 
> [1] http://mails.dpdk.org/archives/dev/2018-September/110959.html
> [2] http://mails.dpdk.org/archives/dev/2019-February/124457.html
> [3] http://mails.dpdk.org/archives/dev/2019-February/124938.html
> 
> Ian Stokes (5):
>   net/i40e: set min and max MTU for i40e devices
>   net/i40e: set min and max MTU for i40e VF devices
>   net/ixgbe: set min and max MTU for ixgbe devices
>   net/ixgbe: set min and max MTU for ixgbe VF devices
>   net/e1000: set min and max MTU for igb devices
> 
> Stephen Hemminger (1):
>   ethdev: add min/max MTU to device info

Hi Ian, Stephen,

API and driver updates are included in the patchset, but I believe it would be
good to have some application code that uses it as well, I assume testpmd
already has some code to set MTU, can you please update it too accordingly?

Also, what do you think starting a unit test (which has a long term target to
verify all ethdev APIs) that tests 'rte_eth_dev_set_mtu()' API with various values?

In long term all vendors can run this unit test against their HW and verify
ehtdev API implementation of their...