From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] lib: clear experimental version tag in
	linker scripts
Date: Fri, 27 Apr 2018 16:55:20 +0100
Message-ID: <5f87cc42-4254-8898-e1ac-da5412fc93f7@intel.com>
References: <20180427151756.22028-1-ferruh.yigit@intel.com>
 <20180427154227.GB22078@hmswarspite.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Declan Doherty <declan.doherty@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 330ED8E1C
 for <dev@dpdk.org>; Fri, 27 Apr 2018 17:55:24 +0200 (CEST)
In-Reply-To: <20180427154227.GB22078@hmswarspite.think-freely.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/27/2018 4:42 PM, Neil Horman wrote:
> On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote:
>> Remove version tag from experimental block in linker version scripts
>> (.map files).
>>
>> That label is not used by linker and information only. It is useful
>> for version blocks but not useful for experimental block but confusing.
>> Removing those labels.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Neil Horman <nhorman@tuxdriver.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> ---
>>  drivers/net/dpaa/rte_pmd_dpaa_version.map      | 4 +---
>>  lib/librte_cryptodev/rte_cryptodev_version.map | 2 +-
>>  lib/librte_eal/rte_eal_version.map             | 2 +-
>>  lib/librte_ethdev/rte_ethdev_version.map       | 2 +-
>>  lib/librte_eventdev/rte_eventdev_version.map   | 2 +-
>>  lib/librte_mbuf/rte_mbuf_version.map           | 3 +--
>>  lib/librte_mempool/rte_mempool_version.map     | 3 +--
>>  lib/librte_meter/rte_meter_version.map         | 2 +-
>>  lib/librte_net/rte_net_version.map             | 2 +-
>>  lib/librte_pipeline/rte_pipeline_version.map   | 2 +-
>>  lib/librte_vhost/rte_vhost_version.map         | 2 +-
>>  11 files changed, 11 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> index 3b937b10f..c7ad4030a 100644
>> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> @@ -9,6 +9,4 @@ EXPERIMENTAL {
>>  	dpaa_eth_eventq_attach;
>>  	dpaa_eth_eventq_detach;
>>  	rte_pmd_dpaa_set_tx_loopback;
>> -
>> -	local: *;
> Are you sure you meant to remove this local tag?  

Yes, it was a duplicate, above DPDK_17.11 one has it already.

> 
> Everything else looks good
> 
> Neil
>