From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v2] ethdev: remove driver name from device private data Date: Wed, 7 Jun 2017 10:22:42 +0530 Message-ID: <5f9f3914-ab05-11a7-2fe5-1eb143c47f90@nxp.com> References: <20170526111502.92063-1-ferruh.yigit@intel.com> <20170606151008.62680-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hurd , Ajit Khaparde , Declan Doherty , Rahul Lakkireddy , Hemant Agrawal , Helin Zhang , Jingjing Wu , Wenzhuo Lu , Konstantin Ananyev , Bruce Richardson , Pascal Mazon , Shrikrishna Khare , Jianfeng Tan , Thomas Monjalon , , Gaetan Rivet , Jan Blunck To: Ferruh Yigit Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0078.outbound.protection.outlook.com [104.47.42.78]) by dpdk.org (Postfix) with ESMTP id 718C42B91 for ; Wed, 7 Jun 2017 06:44:41 +0200 (CEST) In-Reply-To: <20170606151008.62680-1-ferruh.yigit@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 06 June 2017 08:40 PM, Ferruh Yigit wrote: > rte_driver->name has the driver name and all physical and virtual > devices has access to it. > > Previously it was not possible for virtual ethernet devices to access > rte_driver->name field (because eth_dev used to keep only pci_dev), > and it was required to save driver name in the device private struct. > > After re-works on bus and vdev, it is possible for all bus types to > access rte_driver. > > It is able to remove the driver name from ethdev device private data and > use eth_dev->device->driver->name. > > Signed-off-by: Ferruh Yigit > --- > Cc: Gaetan Rivet > Cc: Jan Blunck > > v2: > * rebase on latest next-net > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > drivers/net/bonding/rte_eth_bond_api.c | 4 ++-- > drivers/net/cxgbe/sge.c | 6 +++--- > drivers/net/dpaa2/dpaa2_ethdev.c | 1 - > drivers/net/i40e/i40e_ethdev.c | 3 +-- > drivers/net/i40e/i40e_fdir.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > drivers/net/ring/rte_eth_ring.c | 1 - > drivers/net/tap/rte_eth_tap.c | 1 - > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- > drivers/net/xenvirt/rte_eth_xenvirt.c | 1 - > lib/librte_ether/rte_ethdev.c | 8 ++++---- > lib/librte_ether/rte_ethdev.h | 1 - > lib/librte_ether/rte_ethdev_pci.h | 1 - > lib/librte_ether/rte_ethdev_vdev.h | 1 - > 15 files changed, 14 insertions(+), 22 deletions(-) > Apologies for delay in responding. I am OK with respect to the dpaa2 change. Otherwise as well: Acked-by: Shreyansh Jain