From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 4/4] igb_uio: bind error if pcie bridge
Date: Mon, 26 Mar 2018 19:20:55 +0100
Message-ID: <5fa0e9d9-9c64-c1e8-423d-e9d4441d5b3c@intel.com>
References: <20180321180629.58318-1-ajit.khaparde@broadcom.com>
 <20180321180629.58318-5-ajit.khaparde@broadcom.com>
 <9c01c36e-b2a3-db28-f9b8-ccae8f33e71d@intel.com>
 <f59f25bc-9cb6-5ad7-5921-d616ebadc2ec@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Darren Edamura <darren.edamura@broadcom.com>,
 Rahul Gupta <rahul.gupta@broadcom.com>
To: Scott Branden <scott.branden@broadcom.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id E1D682C5E
 for <dev@dpdk.org>; Mon, 26 Mar 2018 20:21:01 +0200 (CEST)
In-Reply-To: <f59f25bc-9cb6-5ad7-5921-d616ebadc2ec@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/26/2018 7:05 PM, Scott Branden wrote:
> Hi Ferruh,
> 
> 
> On 18-03-26 10:24 AM, Ferruh Yigit wrote:
>> On 3/21/2018 6:06 PM, Ajit Khaparde wrote:
>>> From: Darren Edamura <darren.edamura@broadcom.com>
>>>
>>> Probe function should exit immediately if pcie bridge detected
>>>
>>> Signed-off-by: Darren Edamura <darren.edamura@broadcom.com>
>>> Signed-off-by: Rahul Gupta <rahul.gupta@broadcom.com>
>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>>> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>>> ---
>>>   lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>>> index 4cae4dd27..3fabbfc4d 100644
>>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>>> @@ -473,6 +473,9 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>>>   	void *map_addr;
>>>   	int err;
>>>   
>>> +	if (pci_is_bridge(dev))
>>> +		return -ENODEV;
>> What do you think printing a log here?
> I think it brings little value.  ENODEV is already returned?

User should not provide bridge address at first place, I guess this is a
protection in case user provides bridge address by mistake.
In that case no device will be probed and user won't have any idea why.
I think a log in dmesg saying bridge device is provided may help to the user.

>>
>>> +
>>>   	udev = kzalloc(sizeof(struct rte_uio_pci_dev), GFP_KERNEL);
>>>   	if (!udev)
>>>   		return -ENOMEM;
>>>
> Regards,
>   Scott
>