From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anand Rawat <anand.rawat@intel.com>
Subject: Re: [PATCH v7 1/8] eal: eal stub to add windows support
Date: Mon, 1 Apr 2019 10:06:18 -0700
Message-ID: <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190328232451.16988-1-anand.rawat@intel.com>
 <20190328232451.16988-2-anand.rawat@intel.com>
 <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com, thomas@monjalon.net
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 90E005323
 for <dev@dpdk.org>; Mon,  1 Apr 2019 19:06:21 +0200 (CEST)
In-Reply-To: <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/1/2019 9:34 AM, Bruce Richardson wrote:
> On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote:
>>   config/meson.build                      | 23 ++++++++++++------
>>   config/x86/meson.build                  | 14 ++++++-----
>>   lib/librte_eal/meson.build              |  6 ++++-
>>   lib/librte_eal/windows/eal/eal.c        | 14 +++++++++++
>>   lib/librte_eal/windows/eal/eal_debug.c  | 15 ++++++++++++
>>   lib/librte_eal/windows/eal/eal_lcore.c  | 32 +++++++++++++++++++++++++
>>   lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++
>>   lib/librte_eal/windows/eal/meson.build  | 10 ++++++++
> 
> I'm a little uncertain behind putting the stub files and the meson.build
> changes in the one patch, since the result doesn't build anyway. However,
> you can get meson to successfully configure the project on windows by
> adding in an empty file called meson.build to the kernel/windows directory.
> 
> /Bruce
> 

Thanks Bruce, libm is a part of V8 fixes.
kernel/windows directory is the patch 8/8 as I thought of it as a 
temporary workaround. I'll move it to another patch along with meson 
changes here.
-- 
Anand Rawat