From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 00/42] Remove struct eth_driver Date: Fri, 14 Apr 2017 15:09:37 +0200 Message-ID: <6042261.q63DMppQd2@xps13> References: <1488794430-25179-1-git-send-email-jblunck@infradead.org> <20170412092519.3a29fb55@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Stephen Hemminger , bruce.richardson@intel.com To: Gaetan Rivet , Jan Blunck , pablo.de.lara.guarch@intel.com, jerin.jacob@caviumnetworks.com Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 09F3E37A6 for ; Fri, 14 Apr 2017 15:09:40 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id t189so65164339wmt.1 for ; Fri, 14 Apr 2017 06:09:39 -0700 (PDT) In-Reply-To: <20170412092519.3a29fb55@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-04-12 09:25, Stephen Hemminger: > On Tue, 11 Apr 2017 17:44:07 +0200 > Gaetan Rivet wrote: > > > I rebased the following work of Jan: > > > > This series is removing the PCI specific struct eth_driver from rte_ether. The > > PCI drivers are changed to use the newly introduced header-only helpers > > instead. Although the virtual drivers did not make use of the ethdev's driver > > field they are converted to use the VDEV specific allocation helpers. The > > motivation for this change is to properly embed a reference to the generic > > rte_device in the ethdev. > > > > The series is based on: > > > > * http://dpdk.org/dev/patchwork/patch/20416/ > > * http://dpdk.org/dev/patchwork/patch/20417/ > > * The "Rework vdev probing to use rte_bus infrastructure" series > > * http://dpdk.org/dev/patchwork/patch/21058/ > > > > Changes in v2: > > * Removed the patch "net/vmxnet3: use library function for DMA zone reserve" > > It is essentially duplicating the following commit: > > 04df93d1edac ("net/vmxnet3: fix queue size changes") > > * Fixed header includes for mlx4 and mlx5 PMD > > * Followed the changes of the series for new PMDs (AVP, liquidio) > > * Made KNI use the new API > > * Made PCAP use the new API > > * Fixed undefined behavior on vdev driver arg parsing > > * Fixed virtual_pmd for unit test > > Looks good. > > Acked-by: Stephen Hemminger Applied, thanks Now we need to remove struct rte_pci_driver pci_drv; from cryptodev and eventdev. Sooner is better :) Thanks