From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 09/13] vhost: add API bind a virtq to a specific core Date: Tue, 20 Oct 2015 09:17:12 +0200 Message-ID: <6043116.50yYGaQjqT@xps13> References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com> <20151020062559.GR3115@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "marcel@redhat.com" , "Michael S. Tsirkin" To: Yuanhan Liu Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 4408E8E8A for ; Tue, 20 Oct 2015 09:18:17 +0200 (CEST) Received: by wicfv8 with SMTP id fv8so14206638wic.0 for ; Tue, 20 Oct 2015 00:18:17 -0700 (PDT) In-Reply-To: <20151020062559.GR3115@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-20 14:25, Yuanhan Liu: > On Tue, Oct 20, 2015 at 06:16:23AM +0000, Xie, Huawei wrote: > > On 10/9/2015 1:46 PM, Yuanhan Liu wrote: > > > From: Changchun Ouyang > > > > > > The new API rte_vhost_core_id_set() is to bind a virtq to a specific > > > core, while the another API rte_vhost_core_id_get() is for getting > > > the bind core for a virtq. > > Where is the absolute necessity to put switching/application logic into > > vhost virt queue structure? > > I don't think it's a must, and we can drop it. Yes please, it looks to be a layer violation. Holy rule ;)